fix: close get-prompt modal on backdrop click#179
Merged
tomasz-tomczyk merged 1 commit intomainfrom May 5, 2026
Merged
Conversation
Use phx-click-away on the dialog body to dismiss when the user clicks the overlay backdrop. Updates AGENTS.md to recommend phx-click-away over a colocated hook for click-outside-to-close. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 79.14% 79.14%
=======================================
Files 56 56
Lines 1817 1817
=======================================
Hits 1438 1438
Misses 379 379
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phx-click-away={JS.hide(to: "#crit-prompt-panel")}on the prompt dialog body so clicking the backdrop dismisses the "Get prompt" / "Act on comments" overlay.AGENTS.mdto recommendphx-click-awayover a colocated hook for click-outside-to-close (the binding only fires when the bound element is visible, so there's no race with the open click).Review
Test plan
See also: tomasz-tomczyk/crit#470 (companion fix for the Finish Review modal in crit/).
🤖 Generated with Claude Code