docs: rewrite AGENTS.md with <important if> blocks#165
Merged
tomasz-tomczyk merged 1 commit intomainfrom May 2, 2026
Merged
Conversation
Use targeted relevance conditions per the improve-claude-md pattern so domain-specific guidance (HEEx, LiveView, Ecto, CSS rules) only competes for attention when it actually applies. Foundational context (project map, key architecture) stays bare. Also reconciled the file with current code: - Document size limit corrected: 5 MB → 10 MB (@max_total_size in reviews.ex) - Identity now flows through Phoenix 1.8 Crit.Accounts.Scope + CritWeb.UserAuth (Plugs.Identity no longer exists) - Review/Comment schemas updated to actual fields (review_round, cli_args, scope, author_identity, file_path, quote, external_id) - review_file.ex → review_round_snapshot.ex - mix precommit actually runs deps.unlock --unused + sobelow --skip - Removed fictional 500-comments-per-review limit; added real ones (40-char display name, 500-char file path, 64x256-byte CLI args) - Added missing routes (/auth/cli/*, /api/device/*, /api/auth/*, PUT /api/reviews/:token, /dashboard, /settings, /overview, /health), controllers, LiveViews, and OAuth/device-flow modules - Stack updated to Phoenix 1.8.5 / LiveView 1.1 / Bandit / Elixir 1.19.5 / OTP 28.1 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=======================================
Coverage 77.28% 77.28%
=======================================
Files 55 55
Lines 1651 1651
=======================================
Hits 1276 1276
Misses 375 375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<important if="...">blocks so each section only competes for attention when its trigger condition matches the current task. Foundational context (project map, key architecture) stays bare. Pattern from theimprove-claude-mdskill.@max_total_sizeinreviews.ex)Plugs.Identityno longer exists; identity now flows through Phoenix 1.8Crit.Accounts.Scope+CritWeb.UserAuth. Updated bullet + plug list, added pointer tolib/crit_web/CLAUDE.mdfor the scope contractreview_round,cli_args, dropped non-existentdocumentfield) and Comment (scope,author_identity,author_display_name,file_path,quote,external_id)review_file.ex→review_round_snapshot.exmix precommit: actually runsdeps.unlock --unused+sobelow --skip— spelled out/auth/cli/*,/api/device/*,/api/auth/*,PUT /api/reviews/:token,OPTIONS /api/reviews,/dashboard,/settings,/overview,/health,/integrations/:tooldevice,device_api,auth_api,oauthcontrollers;dashboard,settings,overview,tokensLiveViews;accounts/,user.ex,user_api_token.ex,device_code*,statistics,config.ex,sentry_*DB_PORT=5433for local Postgres; CI usesmix coveralls.json.Review
Test plan
router.ex, schemas matchcomment.ex/review.ex, limits matchreviews.ex, CI step list matches.github/workflows/ci.yml,mix precommitalias matchesmix.exsSee also: tomasz-tomczyk/crit#431 (sibling rewrite)
🤖 Generated with Claude Code