feat: review conversation parity (crit/#374, crit#405)#148
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 30, 2026
Merged
feat: review conversation parity (crit/#374, crit#405)#148tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
Ports the Review Conversation feature from crit/ (PR #405) to crit-web/.
Replaces the hidden "+ Add" button in the comments panel with a
top-of-document Review Conversation section and a sibling tree-section
above FILES in the sidebar. Both surfaces use the typography-driven
Linear treatment from crit/ — no card chrome, no rails — and a shared
ghost "Add comment" button that auto-closes when the user starts
another comment form.
Changes:
- New #reviewConversation section above #document-renderer; threads
+ compose/edit form render inline. data-doc-layout="centered" in
single-doc mode, left-anchored in multi-file (git-style) view.
- New #treeConversationSection row above the file tree FILES header,
with a tabular-nums unresolved badge.
- Shift+G opens the inline form (no longer the panel form). Esc
cancels, Ctrl+Enter submits. Editing review comments now happens
inline — the panel cards are read-only mirrors that scroll back to
the inline section and flash via .comment-flash.
- ] / [ comment navigation now picks up inline review-conversation
cards (was scoped to #document-renderer only).
- Auto-close: opening another comment/reply form closes an empty
review form, and vice-versa.
- Section is collapsible, persisted via localStorage
('crit-review-conversation-collapsed') matching other view prefs.
- Removed the .comments-panel-add-btn (and its CSS) — its function
moved to the inline ghost button.
Backend: Comment.scope == "review" was already supported by the
schema and add_comment / edit_comment / delete_comment / resolve /
reply LiveView events — no schema or context changes needed.
Naming differences from crit/:
- --crit-content-width instead of --content-width
- --crit-editor-bg-elevated instead of --crit-editor-bg-hover
- localStorage instead of cookies (matches crit-web's other prefs)
- .comment-flash instead of .comment-card-highlight
Closes the parity gap with crit/ PR
tomasz-tomczyk/crit#405 (closes crit/#374).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage 77.37% 77.37%
=======================================
Files 55 55
Lines 1653 1653
=======================================
Hits 1279 1279
Misses 374 374
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the Review Conversation feature from
crit/(PR #405) tocrit-web/.Replaces the hidden "+ Add" button in the comments panel with a top-of-document Review Conversation section and a sibling tree-section above FILES in the sidebar. Both surfaces use the typography-driven Linear treatment from
crit/— no card chrome, no rails — and a shared ghost "Add comment" button that auto-closes when the user starts another comment form.Changes
#reviewConversationsection above#document-renderer; threads + compose/edit form render inline.data-doc-layout="centered"in single-doc mode, left-anchored in multi-file (git-style) view.#treeConversationSectionrow above the file tree FILES header, with a tabular-nums unresolved badge.Shift+Gopens the inline form (no longer the panel form).Esccancels,Ctrl+Entersubmits. Editing review comments now happens inline — the panel cards are read-only mirrors that scroll back to the inline section and flash via.comment-flash.] / [comment navigation now picks up inline review-conversation cards (was scoped to#document-rendereronly).localStorage(crit-review-conversation-collapsed) — matches other view prefs incrit-web..comments-panel-add-btn(and its CSS). Its function moved to the inline ghost button.Backend
Comment.scope == "review"was already supported by the schema and theadd_comment/edit_comment/delete_comment/resolve/replyLiveView events — no schema or context changes needed.Naming adapted to crit-web conventions
--crit-content-width(not--content-width)--crit-editor-bg-elevated(no--crit-editor-bg-hoverexists in crit-web)localStorage(not cookies — matches crit-web's other prefs).comment-flash(not.comment-card-highlight)Test plan
Shift+Gopens the inline form with focusEsccancels,Ctrl+Entersubmits]/[navigation cycles through review-conversation cards alongside line/file cardsmix precommitpasses (verified locally)🤖 Generated with Claude Code