fix: align light theme with modern GitHub for visible diff highlights#138
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 29, 2026
Merged
fix: align light theme with modern GitHub for visible diff highlights#138tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
Mirrors the crit-mono parity rule for the review page (this file ↔ crit/frontend/theme.css). The light theme used low-alpha rgba overlays for diff highlights, which visually rendered as near-white and made additions/deletions hard to see. Switch to opaque Primer v8 values (#dafbe1, #aceebb, #ffebe9, #ffcecb) so highlights are perceptible against the page background. Also align the rest of the editor's light tokens to current Primer v8 (editor bg/fg, surfaces, hljs syntax tokens). Three small AA-driven divergences from GH for axe compliance: built_in #953800, deletion gutter num and word-del-nested hljs groups darkened to #1f2328. Dark theme (Tokyo Night) untouched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Merged
6 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=======================================
Coverage 77.21% 77.21%
=======================================
Files 52 52
Lines 1567 1567
=======================================
Hits 1210 1210
Misses 357 357
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#dafbe1,#aceebb,#ffebe9,#ffcecb) so additions/deletions are visible against the page background.hljs-built_indarkened to#953800; deletion-row gutter line numbers and.hljs-* > .diff-word-delgroups darkened to#1f2328.Mirrors crit/ — pairs with tomasz-tomczyk/crit#387 for the crit-mono review-page parity rule.
Review
Test plan
mix precommitpasses locally (471 tests, 0 failures)🤖 Generated with Claude Code