Skip to content

fix: header context chip colors and hidden unresolved count#486

Merged
tomasz-tomczyk merged 1 commit intomainfrom
fix/header-context-colors
May 7, 2026
Merged

fix: header context chip colors and hidden unresolved count#486
tomasz-tomczyk merged 1 commit intomainfrom
fix/header-context-colors

Conversation

@tomasz-tomczyk
Copy link
Copy Markdown
Owner

@tomasz-tomczyk tomasz-tomczyk commented May 7, 2026

Summary

  • Add background + border-color to .header-chip.header-context using --crit-brand-subtle / --crit-brand-bg so the active branch chip has a visible tint in all four themes
  • Add hidden_unresolved to the session API response: the count of unresolved comments on files outside the current focused/scoped view. The finish-button label (Approve vs Finish Review) now correctly accounts for comments the user can't see in the current scope
  • Fixed a TOCTOU in the original approach: total and scope-unresolved counts are now computed under the same RLock in snapshotForScoped

Review

  • Code review: passed
  • Parity audit: N/A (header chip and finish-button CTA are crit-local only)

Test plan

  • Existing test suite passes (go test -race ./...)
  • Manual: verify header chip shows tint in light/dark/system themes
  • Manual: verify finish button shows "Finish Review" when unresolved comments exist on out-of-scope files while in a scoped view

🤖 Generated with Claude Code

@tomasz-tomczyk
fix: header context chip colors and hidden unresolved comment count
a2178da 
- Add background + border-color to .header-chip.header-context using
  --crit-brand-subtle / --crit-brand-bg so the active branch chip has
  a visible tint in all themes
- Track hidden_unresolved (unresolved comments outside the current
  focused view) and factor it into the Approve / Finish Review CTA
  label; computed under a single RLock to avoid TOCTOU; renamed from
  other_scope_unresolved for clarity
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.92%. Comparing base (ac054a5) to head (a2178da).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
session_focus.go 85.29% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   68.88%   68.92%   +0.04%     
==========================================
  Files          45       45              
  Lines       10924    10945      +21     
==========================================
+ Hits         7525     7544      +19     
- Misses       2827     2829       +2     
  Partials      572      572
Flag Coverage Δ
e2e 32.12% <85.29%> (+0.17%) ⬆️
unit 67.09% <67.64%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tomasz-tomczyk tomasz-tomczyk merged commit df897e1 into main May 7, 2026
10 checks passed
@tomasz-tomczyk tomasz-tomczyk deleted the fix/header-context-colors branch May 7, 2026 14:33
@BrewTestBot BrewTestBot mentioned this pull request May 8, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tomasz-tomczyk