fix: deny rather than silently auto-approve on daemon shutdown#483
Merged
tomasz-tomczyk merged 1 commit intomainfrom May 7, 2026
Merged
Conversation
handleReviewCycle ignored server-shutdown SSE events, so the handler kept
blocking through graceful shutdown until the HTTP server force-closed the
connection. Client-side, runReviewClientRaw mapped every error path to
(true, "") — silently approving the plan-hook PermissionRequest whenever
the daemon died.
Now: server emits a 503 + {status:"shutdown", approved:false} payload when
the shutdown event fires, and the client returns approved=false with an
explanatory prompt for unreachable / malformed / unexpected-status cases
so the hook denies (with reason) instead of silently allowing.
Adds regression tests covering both the structured shutdown response and
a hard connection drop mid-request.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (5.26%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
==========================================
- Coverage 69.27% 69.22% -0.06%
==========================================
Files 43 43
Lines 10817 10829 +12
==========================================
+ Hits 7494 7496 +2
- Misses 2755 2765 +10
Partials 568 568
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleReviewCycleignoredserver-shutdownSSE events, so the handler kept blocking through graceful shutdown until the HTTP server force-closed the connection.runReviewClientRawthen mapped every error path to(true, "")— silently approving the plan-hook PermissionRequest whenever the daemon died (graceful shutdown, crash, orcrit stop).Fix
503with{status:"shutdown", approved:false, prompt}when the shutdown event fires (Content-Type set before WriteHeader sowriteJSONdoesn't drop it).approved=falsewith an explanatory prompt for unreachable / malformed-body / unexpected-status / 503-shutdown cases, so the hook denies (with reason) instead of silently allowing.Review
Test plan
TestRunReviewClientRaw_DaemonShutdownDeniesNotApproves:approved=false, non-empty promptapproved=false, non-empty promptTestRunReviewClientRaw_*(readiness / no-delay) still greengo test ./...,gofmt,golangci-lintall clean🤖 Generated with Claude Code