Skip to content

fix: remove daemon 1h idle timeout#477

Merged
tomasz-tomczyk merged 1 commit intomainfrom
fix/476-remove-daemon-idle-timeout
May 7, 2026
Merged

fix: remove daemon 1h idle timeout#477
tomasz-tomczyk merged 1 commit intomainfrom
fix/476-remove-daemon-idle-timeout

Conversation

@tomasz-tomczyk
Copy link
Copy Markdown
Owner

@tomasz-tomczyk tomasz-tomczyk commented May 7, 2026

Summary

  • Drop the 1-hour idle-kill in the daemon's serve loop. Reporter (Premature closure on Claude Code #476) was losing the review UI mid-session when stepping away for meetings or overnight.
  • At this scale (single-user localhost, embedded frontend, <50 files/comments) an idle daemon is tens of MB with self-gating watchers — costs less than the browser tab pointed at it. Process still exits via SIGINT/SIGTERM/SIGHUP and `crit stop`.
  • Validated by go-expert: no leaks the timeout was masking, watchers (`watch.go`) already gate expensive work behind `isWaitingForAgent()`.

Review

  • Code review: passed (`/crit-review` — intent audit CLEAN, no parity surface, no security surface)
  • Parity audit: N/A (Go-only)

Test plan

  • `go build ./...`, `go vet ./...`, `gofmt -l .` clean
  • `go test ./...` passes
  • `golangci-lint run ./...` passes (pre-commit)

Closes #476

🤖 Generated with Claude Code

@tomasz-tomczyk
fix: remove daemon 1h idle timeout
bc2681c 
The idle-kill was overcautious — at this scale (single-user localhost,
embedded frontend, <50 files/comments) the daemon costs less than a
browser tab, and the timeout actively broke the documented "walk away
and come back" workflow when a review spans meetings or overnight.

Process still exits via SIGINT/SIGTERM/SIGHUP and `crit stop`.

Closes #476
@tomasz-tomczyk tomasz-tomczyk merged commit eac616c into main May 7, 2026
6 checks passed
@tomasz-tomczyk tomasz-tomczyk deleted the fix/476-remove-daemon-idle-timeout branch May 7, 2026 07:45
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.18%. Comparing base (bc7509f) to head (bc2681c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   69.19%   69.18%   -0.02%     
==========================================
  Files          36       36              
  Lines       10759    10736      -23     
==========================================
- Hits         7445     7428      -17     
+ Misses       2750     2746       -4     
+ Partials      564      562       -2
Flag Coverage Δ
e2e 32.28% <100.00%> (-0.12%) ⬇️
unit 66.89% <0.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TalAmuyal
Copy link
Copy Markdown
Contributor

TalAmuyal commented May 7, 2026

Awesome, thanks! (will try it as soon as there is a release for that ❤️)

@BrewTestBot BrewTestBot mentioned this pull request May 8, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Premature closure on Claude Code

2 participants

@tomasz-tomczyk @TalAmuyal