fix: post-v0.10.4 release audit cleanup#475
Merged
tomasz-tomczyk merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
- watch.go: carryForwardComment now copies ResolvedRound (Stage-1 timeline requires both Resolved and ResolvedRound; without this, resolved comments lose their round metadata across markdown rounds) - cli_install.go: 'install all' now exits non-zero on partial failures - focus_cli.go/main.go: drop dead outputDir param from probeDaemonFocus (and from resolvePullScope, which only used it for that call) - daemon_e2e_test.go: localhost -> 127.0.0.1 to match daemon bind - share_integration_test.go: fix stale .crit.json comment
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (54.54%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
==========================================
+ Coverage 69.17% 69.19% +0.02%
==========================================
Files 36 36
Lines 10744 10749 +5
==========================================
+ Hits 7432 7438 +6
- Misses 2747 2748 +1
+ Partials 565 563 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
carryForwardCommentnow copiesResolvedRound— Stage-1 timeline (round_snapshots.go) requires bothResolvedandResolvedRound; resolved comments would otherwise lose their round metadata across markdown rounds.crit install allnow exits non-zero on partial failures (single-target path was already correct).outputDirparam fromprobeDaemonFocus(andresolvePullScope, which only threaded it to that call).daemon_e2e_test.go:localhost→127.0.0.1to match daemon bind (commit 95b8ab7 fixed prod).share_integration_test.go: fix stale.crit.jsoncomment (actual write is.crit/review.json).Review
Test plan
🤖 Generated with Claude Code