fix: backward selection across blank-line boundary#473
Merged
tomasz-tomczyk merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
Replace anchorNode/focusNode inspection in getLineRangeFromSelection with Range.intersectsNode() so selection-to-comment is direction- agnostic. Backward drags across a blank-line/paragraph boundary could leave one endpoint snapped to the parent container between line-blocks (no .line-block ancestor), causing the range to collapse to a single endpoint or the comment form to fail to open. Walks .line-block and diff-line elements and unions the line ranges of every element the selection range intersects. Same semantics for single-block selections; robust for multi-block and gap-endpoint cases. Adds e2e regression test that constructs the gap-endpoint Selection programmatically (Playwright headless doesn't reproduce the browser snap behavior with a simple mouse drag).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
==========================================
+ Coverage 69.17% 69.22% +0.05%
==========================================
Files 36 36
Lines 10744 10744
==========================================
+ Hits 7432 7438 +6
+ Misses 2747 2743 -4
+ Partials 565 563 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getLineRangeFromSelectionto walk every.line-blockand[data-diff-line-num]element and union the line ranges of those the selection'sRangeintersects, instead of only inspectingselection.anchorNode/focusNode.closest('.line-block')returns null; the new approach is direction-agnostic and robust to gap-endpoint positions.Review
Test plan
assets/js/document-renderer.js)🤖 Generated with Claude Code