feat: keyboard-accessible sidebar resize handles#469
Merged
tomasz-tomczyk merged 3 commits intomainfrom May 5, 2026
Merged
Conversation
Add role="separator" tabindex="0" aria-orientation="vertical" to the file-tree and comments-panel resize handles, plus ArrowLeft/ArrowRight keydown that nudges width by 16px (clamped to per-handle minimum). Replaces the previous aria-hidden="true" that hid the handles from assistive tech entirely. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Keyboard users tabbing to the sidebar resize handles got no focus indicator. Match crit-web's :focus-visible style — the brand-color strip already used for hover/dragging, with outline:none so the default browser ring doesn't double up.
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
==========================================
+ Coverage 69.15% 69.18% +0.02%
==========================================
Files 36 36
Lines 10749 10736 -13
==========================================
- Hits 7434 7428 -6
+ Misses 2749 2744 -5
+ Partials 566 564 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Per ARIA spec, role="separator" with tabindex="0" requires aria-valuenow (plus min/max). Static 50/0/100 satisfies the contract; the handle's operational behavior (arrow keys, drag) doesn't depend on these values. Fixes axe-core aria-required-attr violation in the e2e suite. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sidebar resize handles gain keyboard support and a focus indicator.
aria-hidden="true"and were unreachable by keyboard. Now userole="separator",tabindex="0",aria-orientation="vertical", with ArrowLeft/ArrowRight nudging width by 16px (clamped to min, persists via existing settings cookie).:focus-visiblebrand-color style so keyboard users can see the focused handle.Companion to tomasz-tomczyk/crit-web#177, which ports the resizable-sidebars feature itself plus this same a11y polish to the hosted review surface.
Review
Test plan
🤖 Generated with Claude Code