fix: relax comment drift detection for in-place edits#466
Merged
tomasz-tomczyk merged 2 commits intomainfrom May 5, 2026
Merged
fix: relax comment drift detection for in-place edits#466tomasz-tomczyk merged 2 commits intomainfrom
tomasz-tomczyk merged 2 commits intomainfrom
Conversation
Comments were marked as drifted whenever the anchor line changed at all, even when the original text was still a clean prefix of the edited line. Now treats edited-but-recognizable lines as anchored: substring match covers append/trim, Levenshtein ratio (>= 0.7) covers minor rewordings. File-wide search remains exact-match to avoid jumping to look-alike lines elsewhere in the file. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Without a length gate, a 1-2 char anchor like `}` or `return` would trivially anchor to any longer line containing those characters at the LCS row. Gate substring on min(len(a), len(b)) >= 8 so trivial anchors fall through to Levenshtein, which scales correctly with length. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
==========================================
+ Coverage 69.04% 69.25% +0.21%
==========================================
Files 36 36
Lines 10698 10749 +51
==========================================
+ Hits 7386 7444 +58
+ Misses 2748 2743 -5
+ Partials 564 562 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
}/return) covers append/trim, Levenshtein ratio ≥ 0.7 covers minor rewordings.Review
Test plan
go test ./...— all greengofmt -l .clean,golangci-lint run ./...cleanTestCarryForward_AnchorEditedInPlaceNotDrifted— reproduces the real-world scenario where text was appended to a list item.TestAnchorSimilartable — identical, trim, append, minor edit, short-anchor (gated), unrelated, heavy rewrite, multi-line.🤖 Generated with Claude Code