fix: reduced-motion spinner gap; rename waitingHasComments; annotate reflow#465
Merged
tomasz-tomczyk merged 1 commit intomainfrom May 5, 2026
Merged
fix: reduced-motion spinner gap; rename waitingHasComments; annotate reflow#465tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
…nnotate reflow line
- style.css: add .waiting-spinner .dot { animation: none } to reduced-motion block (spinner
was exempt despite being visible during the full non-approved waiting period)
- app.js: rename waitingHasComments → waitingNotApproved (now means !approved, not "has comments")
- app.js: add inline comment to void dialog.offsetWidth explaining it forces reflow for animation replay
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
==========================================
+ Coverage 69.01% 69.04% +0.02%
==========================================
Files 36 36
Lines 10698 10698
==========================================
+ Hits 7383 7386 +3
+ Misses 2750 2748 -2
+ Partials 565 564 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
style.css: add.waiting-spinner .dot { animation: none; opacity: 0.6 }toprefers-reduced-motion: reduceblock — spinner was exempt despite being visible during the full non-approved waiting periodapp.js: renamewaitingHasComments→waitingNotApprovedacross all 4 sites — variable now means!approved, not "has comments"; name was misleading after the approved-state refactorapp.js: add inline comment tovoid dialog.offsetWidthexplaining it forces a reflow to restart CSS animations on re-added classReview
Test plan
prefers-reduced-motion: reducemedia querygrep waitingHasCommentsreturns nothing — rename complete🤖 Generated with Claude Code