refactor: release audit cleanup — atomic writes, flag parsing, dead code#464
Merged
tomasz-tomczyk merged 1 commit intomainfrom May 5, 2026
Merged
refactor: release audit cleanup — atomic writes, flag parsing, dead code#464tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
- installOneFile: use atomicWriteFile (consistent with all other writes post-#430) - aider_install: collapse byte-identical force/!force write branches - cli_install: fix order-sensitive flag parsing (--force before agent name now works) - main: remove dead _ = keys[i] (pre-existing leftover) - share: delete test-only buildLocalFingerprints shim; tests now call buildLocalFingerprintIndex directly - cli_serve: add comment clarifying bindListener retry semantics (explicit port retries, ephemeral fails fast)
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (36.36%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
==========================================
+ Coverage 69.01% 69.05% +0.03%
==========================================
Files 36 36
Lines 10698 10698
==========================================
+ Hits 7383 7387 +4
+ Misses 2750 2747 -3
+ Partials 565 564 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli_install.goinstallOneFile: useatomicWriteFile(crash-safe, consistent with all other writes post-refactor: consolidate atomic-file-write helpers #430)aider_install.go: collapse byte-identicalforce/!forcewrite branches into onecli_install.gorunInstall: fix order-sensitive flag parsing —--forcenow accepted before or after the agent namemain.go: remove dead_ = keys[i](pre-existing leftover from refactor)share.go: delete test-onlybuildLocalFingerprintsshim; tests now callbuildLocalFingerprintIndexdirectlycli_serve.go: add comment clarifyingbindListenerretry semantics (explicit port retries on transient contention; ephemeral port fails fast)Review
Test plan
go test -race -count=1 ./...— passgolangci-lint run ./...— 0 issuesgofmt -l .— clean🤖 Generated with Claude Code