feat: distinct "Approved" state for review-finish modal#427
Merged
tomasz-tomczyk merged 1 commit intomainfrom May 2, 2026
Merged
feat: distinct "Approved" state for review-finish modal#427tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
The post-finish modal previously showed the same dot spinner and "Waiting for updates" copy in every case — including approvals where no further work is expected. This was confusing when a plan was approved with no comments to process. When `/api/finish` returns `approved=true`, the modal now switches to an animated success-mark (green ring + check, drawn one-shot, glow afterward), heading "Approved", and conclusive copy. The prompt block and Copy button are hidden in that state — the prompt is still auto-copied to the clipboard so the manual-paste fallback is preserved silently. `prefers-reduced-motion` disables the draw animations. Waiting state (data.approved=false) is unchanged. Also adds two missing regression tests for Ctrl+Enter on comment-edit and reply-edit textareas, matching the existing reply-create coverage. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
+ Coverage 67.38% 67.41% +0.03%
==========================================
Files 26 26
Lines 9747 9747
==========================================
+ Hits 6568 6571 +3
+ Misses 2663 2661 -2
+ Partials 516 515 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/finishreturnsapproved=true, the waiting modal now shows an animated success-mark (green ring + check), heading "Approved", and conclusive copy instead of the generic spinner. Prompt block and Copy button are hidden in that state — the prompt is still auto-copied to the clipboard so the manual-paste fallback survives silently.prefers-reduced-motiondisables the draw animations.Test plan
make e2e— green🤖 Generated with Claude Code