chore: post-v0.10.4 audit cleanup#426
Merged
tomasz-tomczyk merged 2 commits intomainfrom May 2, 2026
Merged
Conversation
Follow-up to release audit; all P3 nits, no behavior change. - frontend/style.css: drop redundant align-self/height on .sidebar-resize-handle (flex row already stretches it). - github.go: clarify findReviewFileByCommentID godoc to mention the missing/multi-match error case. - server.go: correct cliArgs comment - it holds positional file args only; flags aren't preserved. - server_test.go: rename misleading "flag-style arg passes through" case and note that this exercises shellQuoteArg formatting, not a real call shape. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
+ Coverage 67.38% 67.41% +0.03%
==========================================
Files 26 26
Lines 9747 9747
==========================================
+ Hits 6568 6571 +3
+ Misses 2663 2661 -2
+ Partials 516 515 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The "redundant" claim from the prior cleanup was wrong. With position: sticky, the handle needs an explicit height to be tall enough to drag — without it the handle collapses and three sidebar-resize.spec.ts tests fail in CI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the v0.10.4 release audit. All P3 nits, no behavior change.
.sidebar-resize-handle): dropalign-self: stretchandheight: calc(100vh - var(--header-height))— the flex row already stretches the handle, so both rules were redundant overdetermination.findReviewFileByCommentIDgodoc): document the not-found / multi-match error case so the contract matches the implementation.Server.cliArgsfield comment): correct overstated comment — the field only holds positional file args; flags (--pr,--range, etc.) are not preserved.buildNextCommandtable case): rename misleading"flag-style arg passes through"to"unknown leading-dash arg formats verbatim"and add a note that this exercisesshellQuoteArgformatting, not a real runtime call shape (cliArgsonly holds positional args at runtime).Test plan
go vet ./...cleango test ./...passesgofmt -l .clean🤖 Generated with Claude Code