fix: prevent review comment form re-opening pre-populated after submit#419
Merged
tomasz-tomczyk merged 1 commit intomainfrom May 2, 2026
Merged
Conversation
renderReviewConversation snapshots any non-empty textarea value as a "draft to preserve" so SSE/refresh re-renders don't blow away in-progress typing. After a successful submit the textarea still contained the just- submitted text, so the snapshot captured it and the form was rendered again pre-populated — looking like a duplicate. Clear the textarea explicitly in addReviewComment before re-rendering. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 67.27% 67.30% +0.03%
==========================================
Files 26 26
Lines 9668 9668
==========================================
+ Hits 6504 6507 +3
+ Misses 2653 2651 -2
+ Partials 511 510 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderReviewConversationsnapshots any non-emptyreview:newtextarea as a "draft to preserve" so SSE/refresh re-renders don't blow away in-progress typing. After submit the textarea still held the submitted text, so the snapshot captured it and re-rendered the form pre-populated.review:newtextarea explicitly inaddReviewCommentbefore re-rendering. Doesn't affect the editor (separateformKey).Review
formObj.draftBody, not a DOM-snapshot heuristic — bug doesn't apply)go test -racePASSTest plan
e2e/tests/review-comments.spec.ts— "after submit, form does not re-open pre-populated with submitted text"🤖 Generated with Claude Code