feat: consolidate settings cookies, restore update dismiss#418
Merged
tomasz-tomczyk merged 2 commits intomainfrom May 2, 2026
Merged
feat: consolidate settings cookies, restore update dismiss#418tomasz-tomczyk merged 2 commits intomainfrom
tomasz-tomczyk merged 2 commits intomainfrom
Conversation
- Collapse 8 crit-* preference cookies into a single crit-settings JSON cookie via getSetting/setSetting helpers; crit-templates kept separate (user-defined, can be long). One-time idempotent migration on load expires the legacy cookies. - Restore "Don't remind me until next version" on the Update card in the settings panel (lost in #261 when the modal was replaced). - Add per-agent dismiss to the AI Integration card, keyed on the bundled integration's content hash so the reminder reappears when the template updates. Backend exposes hash on integrationStatus. - Header update indicator now consults a unified predicate that filters both brew and integration entries against their respective dismiss keys. - Style dismiss controls with new .config-card-dismiss / .config-card- dismissed classes that match the existing .config-card-copy ghost- action pattern instead of misusing .about-link.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
==========================================
+ Coverage 67.27% 67.30% +0.03%
==========================================
Files 26 26
Lines 9668 9671 +3
==========================================
+ Hits 6504 6509 +5
+ Misses 2653 2652 -1
+ Partials 511 510 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crit-*preference cookies into a singlecrit-settingsJSON cookie viagetSetting/setSettinghelpers.crit-templatesstays separate (user-defined, can be long). One-time idempotent migration on load expires the legacy cookies. Cookies (not localStorage) because crit defaults to a random port and localStorage is origin-scoped.HashonintegrationStatusso the dismiss expires automatically when a new template ships..config-card-actions,.config-card-dismiss,.config-card-dismissedclasses that match the existing.config-card-copyghost-action vocabulary instead of misusing.about-link.Review
Test plan
go buildcleangofmt -l .cleangolangci-lint run ./...0 issuesgo test ./...pass🤖 Generated with Claude Code