refactor: clean up frontend dead code and fix review:new draft loss#413
Merged
tomasz-tomczyk merged 2 commits intomainfrom May 1, 2026
Merged
refactor: clean up frontend dead code and fix review:new draft loss#413tomasz-tomczyk merged 2 commits intomainfrom
tomasz-tomczyk merged 2 commits intomainfrom
Conversation
Post-release cleanup pass after the stack-popover and review-level comments work landed: - Remove dead diff-area-header / diff-scope-toggle (replaced by the stack popover's "Compare against" radios) - Drop unused .base-branch-arrow CSS alias and stack-popover-default classname (no CSS rule, no E2E reference) - Hoist duplicate clipEl reset in doFinishReview - Use cached baseBranchArrowEl ref in fetchBranches instead of inline getElementById lookups Bug fix: review:new comment drafts were silently wiped when sibling state changes triggered renderReviewConversation re-renders (e.g. adding a reply to an existing thread). Snapshot non-empty draft text before innerHTML='', restore caret + focus after rebuild. Empty drafts are still discarded intentionally. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
=======================================
Coverage 67.32% 67.32%
=======================================
Files 26 26
Lines 9665 9665
=======================================
Hits 6507 6507
Misses 2648 2648
Partials 510 510
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The F7 cleanup removed `stack-popover-default` because no CSS rule used it, but range-mode E2E tests use it as a selector hook (focus-picker / stack-popover specs). Restore it as a dedicated test selector — same rationale as the review-conversation-empty class. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-release cleanup pass after the stack-popover and review-level comments work landed:
diff-area-header/diff-scope-toggle(replaced by the stack popover's "Compare against" radios).base-branch-arrowCSS alias andstack-popover-defaultclassname (no CSS rule, no E2E reference)clipElreset indoFinishReviewbaseBranchArrowElref infetchBranchesinstead of inlinegetElementByIdlookupsBug fix:
review:newcomment drafts were silently wiped when sibling state changes triggeredrenderReviewConversationre-renders (e.g. adding a reply to an existing thread). Snapshot non-empty draft text beforeinnerHTML='', restore caret + focus after rebuild. Empty drafts are still discarded intentionally.Review
review-conversation-emptykept as conditional class for E2E hooks)Test plan
go buildclean (embedded frontend builds)e2e/)🤖 Generated with Claude Code