refactor: return errors from installAider; unify integration list#394
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 29, 2026
Merged
refactor: return errors from installAider; unify integration list#394tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
installAider previously called os.Exit(1) on error, which aborted the `crit install all` loop and prevented other agents from installing. Now returns error like its sibling installAiderAt; runInstall logs and continues for the all-loop, preserves exit-on-error for single targets. availableIntegrations now derives from integrationMap keys + "aider" (sorted) instead of being a hardcoded slice — single source of truth.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
==========================================
+ Coverage 66.60% 66.67% +0.06%
==========================================
Files 19 19
Lines 8206 8211 +5
==========================================
+ Hits 5466 5475 +9
+ Misses 2313 2311 -2
+ Partials 427 425 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
installAiderno longer callsos.Exit(1)— returns error like its siblinginstallAiderAt.crit install allnow logs failures and continues to the next agent instead of aborting the loop.availableIntegrations()derives fromintegrationMapkeys +"aider"(sorted). Single source of truth — adding a new agent only requires updating the map.Review
Test plan
go test ./...(includes integration_routing_test.go, aider_install_test.go) passescrit install allloop exits-on-error UX preserved for single targets🤖 Generated with Claude Code