Skip to content

chore: post-release audit fixes (frontend)#390

Merged
tomasz-tomczyk merged 1 commit intomainfrom
audit/frontend-fixes
Apr 29, 2026
Merged

chore: post-release audit fixes (frontend)#390
tomasz-tomczyk merged 1 commit intomainfrom
audit/frontend-fixes

Conversation

@tomasz-tomczyk
Copy link
Copy Markdown
Owner

Summary

Post-v0.10.1 audit fixes for the frontend.

  • P1 app.js: extract bindSubmitCancelKeys helper; dedup 3 Ctrl+Enter/Escape sites (4th createReplyInput skipped — asymmetric Escape branch)
  • P1 theme.css: consolidate duplicated AA-contrast blocks (36→20 selector lines) across [data-theme=light] and prefers-color-scheme: light
  • P1 theme.css: replace #1f2328 literals with var(--crit-editor-fg)

Test plan

  • node -c frontend/app.js
  • visual check on light theme (CI / manual)

🤖 Generated with Claude Code

- app.js: extract bindSubmitCancelKeys, dedup 3 Ctrl+Enter/Escape sites
- theme.css: consolidate duplicated AA-contrast light-theme blocks
- theme.css: replace #1f2328 literals with var(--crit-editor-fg)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@tomasz-tomczyk tomasz-tomczyk merged commit d8b83bf into main Apr 29, 2026
3 of 4 checks passed
@tomasz-tomczyk tomasz-tomczyk deleted the audit/frontend-fixes branch April 29, 2026 14:52
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.59%. Comparing base (49d4201) to head (287047a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
+ Coverage   66.58%   66.59%   +0.01%     
==========================================
  Files          19       19              
  Lines        8176     8176              
==========================================
+ Hits         5444     5445       +1     
+ Misses       2310     2309       -1     
  Partials      422      422              
Flag Coverage Δ
e2e 34.20% <ø> (+0.13%) ⬆️
unit 62.61% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant