chore: post-release audit fixes (Go backend)#389
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
- auth: lock global config writes to prevent race on identity backfill - auth: log clearAuthIdentity save failures to stderr - main: extract handleShareAuthError, collapse 4 401-handler copies - share: collapse loadCommentsForUpsert into loadCommentsForShare - aider_install: remove unused writeFileMkdir helper - github: replace testing.Testing() with fetchGHUserName seam - github: log gh api lookup failures once per login Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
- Coverage 66.58% 66.57% -0.02%
==========================================
Files 19 19
Lines 8176 8197 +21
==========================================
+ Hits 5444 5457 +13
- Misses 2310 2314 +4
- Partials 422 426 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-v0.10.1 audit fixes for the Go backend.
lazyBackfillAuthUserID)clearAuthIdentitysave failures instead of swallowinghandleShareAuthError, dedup 4 copies (divergent exit-vs-fallthrough behavior preserved intentionally)loadCommentsForUpsertintoloadCommentsForSharewriteFileMkdirtesting.Testing()withfetchGHUserNamefunction-variable seamgh apifailures once per login (cached fallback prevents spam)Test plan
🤖 Generated with Claude Code