fix: Ctrl+Enter to save when editing replies#386
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
editReply built an inline textarea with Save/Cancel buttons but no keydown handler, so Ctrl+Enter was silently ignored once the user hit the pencil on a reply. Match the pattern from createCommentFormUI: Ctrl/Cmd+Enter clicks Save, Escape clicks Cancel. Top-level comment edit already worked via createCommentFormUI; added a regression test for it alongside the new reply-edit test.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
==========================================
+ Coverage 66.56% 66.59% +0.03%
==========================================
Files 19 19
Lines 8176 8176
==========================================
+ Hits 5442 5445 +3
+ Misses 2311 2309 -2
+ Partials 423 422 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
editReplybuilt an inline textarea with Save/Cancel buttons but never attached a keydown listener — Ctrl+Enter was silently ignored once you hit the pencil on a reply.createCommentFormUI(and crit-web'seditReplywhich already had this): Ctrl/Cmd+Enter clicks Save, Escape clicks Cancel.createCommentFormUI; added a regression test for it alongside the new reply-edit test.Review
document-renderer.js:2917-2928already had this handler)Test plan
e2e/tests/comments.spec.ts(top-level comment edit) ande2e/tests/threading.spec.ts(reply edit) — both fail on main without the fix, pass with it.comments.spec.ts+threading.spec.tssuites green (42/42).go test ./...green.Closes #382