feat: distinct "Approved" state for review-finish modal#381
Merged
tomasz-tomczyk merged 2 commits intomainfrom Apr 29, 2026
Merged
feat: distinct "Approved" state for review-finish modal#381tomasz-tomczyk merged 2 commits intomainfrom
tomasz-tomczyk merged 2 commits intomainfrom
Conversation
The post-finish modal showed a dot spinner and "Your agent has been notified. Waiting for updates..." in every case — including approvals where no further work is expected. Drives confusion when a plan is approved with no changes needed. Server already returns data.approved from /api/finish; switch the frontend to read it instead of inferring from prompt presence. When approved, the modal now shows an animated SVG checkmark drawn into a green ring (one-shot, no looping), heading "Approved", and conclusive copy. Prompt block + Copy button are hidden — the prompt is auto-copied to clipboard in doFinishReview, so the manual-paste fallback is preserved silently. Waiting state (data.approved=false) is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
==========================================
+ Coverage 66.58% 66.59% +0.01%
==========================================
Files 19 19
Lines 8176 8176
==========================================
+ Hits 5444 5445 +1
+ Misses 2310 2309 -1
Partials 422 422
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The post-finish modal showed a dot spinner + "Your agent has been notified. Waiting for updates…" in every case, including pure approvals where no further work is expected. The server already returns
approved: boolfrom/api/finish, but the frontend was ignoring it and inferring "is the agent expected to do work?" from prompt presence — so the resolve-all-then-finish path was misclassified and showed the misleading waiting copy.Now the modal has two distinct states driven by
data.approved:doFinishReview, so the manual-paste fallback is preserved silently.Review
Test plan
e2e/tests/round-complete.spec.tsandround-complete.filemode.spec.tsupdated to assert the new.approvedclass + heading🤖 Generated with Claude Code