fix: preserve replies on fingerprint-matched comments + audit cleanup#367
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 26, 2026
Merged
fix: preserve replies on fingerprint-matched comments + audit cleanup#367tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
- Fix data-loss bug where web-authored replies were silently dropped when their parent comment was matched by fingerprint (not external_id) - Replace variadic replyUpdates anti-pattern with fixed map argument - Refactor mergeWebComments to iterate by index (no mid-range mutation) - Log non-NotExist errors in loadCliArgsFromReviewFile (no silent swallow) - Use replyCount in runFetch print message - Rename TestFetchNewWebComments_* → TestFetchWebComments_* - Consolidate duplicated test groups into table-driven subtests - Add TestFetchWebComments_FingerprintMatchPreservesReplies regression - Add TestMergeWebComments_AppliesReplyUpdates coverage - Extract shareReviewFiles helper (dedup runShareNew + handleShare) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (68.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
==========================================
+ Coverage 66.88% 67.19% +0.31%
==========================================
Files 18 18
Lines 7807 7823 +16
==========================================
+ Hits 5222 5257 +35
+ Misses 2193 2176 -17
+ Partials 392 390 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release audit follow-up addressing findings from v0.10.0..HEAD review.
Bug fix (P0):
Refactors:
replyUpdatesanti-pattern with fixed map argumentmergeWebCommentsto iterate by index (no mid-range mutation)loadCliArgsFromReviewFile(no silent swallow)replyCountinrunFetchprint messageshareReviewFileshelper (deduprunShareNew+handleShare)Tests:
TestFetchNewWebComments_*→TestFetchWebComments_*after function renameTestFetchWebComments_FingerprintMatchPreservesRepliesTestMergeWebComments_AppliesReplyUpdatesReview
go vet ./...cleango test -race ./...cleanTest plan
make e2e-share(skipped during audit — requires running crit-web)🤖 Generated with Claude Code