Skip to content

feat: redesign comments panel with segmented filter and collapsible groups#354

Merged
tomasz-tomczyk merged 6 commits intomainfrom
panel-redesign
Apr 24, 2026
Merged

feat: redesign comments panel with segmented filter and collapsible groups#354
tomasz-tomczyk merged 6 commits intomainfrom
panel-redesign

Conversation

@tomasz-tomczyk
Copy link
Copy Markdown
Owner

Summary

  • Two-row header layout: Row 1 has Comments title + count badge, + Add button, and close. Row 2 has segmented filter pill and expand/collapse all toggle.
  • Segmented filter pill (All/Open/Resolved) replaces the old "Show resolved" checkbox toggle, reusing the existing .scope-toggle + .toggle-btn pattern.
  • Collapsible file groups with chevron indicator and per-group comment count badge.
  • Expand all / Collapse all toggle that affects both panel and inline comment cards.

Comment card styling is unchanged.

Test plan

  • Open a review with multiple files containing comments (both open and resolved)
  • Verify two-row header renders: title + badge on row 1, filter pill + expand all on row 2
  • Click each filter pill button (All, Open, Resolved) and confirm correct filtering
  • Verify count badge updates correctly as comments are added/resolved
  • Click file group headers to collapse/expand individual groups
  • Click "Expand all" / "Collapse all" and verify it toggles all comment cards (panel + inline)
  • Test in light, dark, and system themes
  • Confirm no regressions in comment editing, resolving, or adding new comments

🤖 Generated with Claude Code

tomasz-tomczyk and others added 2 commits April 24, 2026 20:42
…roups

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace custom sliding-indicator pill with the existing
.scope-toggle + .toggle-btn pattern used by the diff view.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@tomasz-tomczyk tomasz-tomczyk changed the title Redesign comments panel with segmented filter and collapsible groups feat: redesign comments panel with segmented filter and collapsible groups Apr 24, 2026
tomasz-tomczyk and others added 4 commits April 24, 2026 21:00
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Cover the six key scenarios of the panel redesign:
- Count badge in panel header
- Segmented filter (All/Open/Resolved) with correct filtering
- Filter pill counts matching actual comment totals
- Collapsible file groups with chevron toggle
- Expand all / Collapse all toggle with label state
- Expand/Collapse all affecting inline comment blocks

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Replace .comments-panel-switch-track with new segmented filter pill
  (#commentsFilterPill .toggle-btn[data-filter="resolved"])
- Update empty state text from "No unresolved comments" to "No comments yet"
- Fix expand/collapse all tests: cards start expanded so initial button
  label is "Collapse all", not "Expand all"

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@tomasz-tomczyk tomasz-tomczyk merged commit 0e5d0b4 into main Apr 24, 2026
4 checks passed
@tomasz-tomczyk tomasz-tomczyk deleted the panel-redesign branch April 24, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant