Skip to content

feat: add hide-resolved setting for inline comments#353

Merged
tomasz-tomczyk merged 8 commits intomainfrom
hide-resolved
Apr 24, 2026
Merged

feat: add hide-resolved setting for inline comments#353
tomasz-tomczyk merged 8 commits intomainfrom
hide-resolved

Conversation

@tomasz-tomczyk
Copy link
Copy Markdown
Owner

Summary

  • Adds a "Hide resolved" toggle in the settings panel to hide resolved inline comments from the document body
  • Adds h keyboard shortcut to toggle hide-resolved on/off
  • Persists preference in localStorage (crit-hide-resolved)
  • Re-applies hide state after view switches and file section re-renders

Details

Single-file change in frontend/app.js:

  • applyHideResolved() — scans .comment-block elements (excluding panel comments), hides those containing .resolved-card
  • Settings panel gets a new toggle row reusing the existing .comments-panel-switch styles
  • Keyboard shortcut h added under the View section, syncs the settings toggle if open
  • Called on view switch and file re-render to maintain state

Test plan

  • go build succeeds
  • go test ./... — all failures are pre-existing on main (config resolution tests)
  • Manual: open a review with resolved comments, toggle setting, verify comments hide/show
  • Manual: press h to toggle, verify shortcut works and settings checkbox syncs
  • Manual: switch views (unified/split), verify hidden state persists

🤖 Generated with Claude Code

tomasz-tomczyk and others added 8 commits April 24, 2026 20:41
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Covers settings toggle presence, inline comment hiding, side panel
unaffected, h keyboard shortcut, and localStorage persistence.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The panel toggle interaction is unreliable in CI. The behavior
is inherently correct via the :not(.panel-comment-block) selector
and is covered by the implementation, not an E2E test.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@tomasz-tomczyk tomasz-tomczyk merged commit fdb7dd2 into main Apr 24, 2026
4 checks passed
@tomasz-tomczyk tomasz-tomczyk deleted the hide-resolved branch April 24, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant