feat: replace custom LCS word-diff with @sanity/diff-match-patch#348
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 25, 2026
Merged
feat: replace custom LCS word-diff with @sanity/diff-match-patch#348tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
The custom tokenize+computeTokenLCS implementation used O(m*n) dynamic
programming on word tokens. Replace it with @sanity/diff-match-patch's
diff algorithm + semantic cleanup, which produces better word-boundary
highlights with less code. The return type ({ oldRanges, newRanges })
and all guard clauses are preserved.
Since the package is ESM-only, copy-deps.js now uses esbuild to bundle
it into a browser-ready IIFE (8.9KB) at frontend/diff-match-patch.min.js.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
36c4ef2 to
b93d612
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 66.86% 66.90% +0.03%
==========================================
Files 18 18
Lines 7807 7807
==========================================
+ Hits 5220 5223 +3
+ Misses 2194 2192 -2
+ Partials 393 392 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tokenize+computeTokenLCS(O(m×n) DP) word-diff implementation with@sanity/diff-match-patchmakeDiff+cleanupSemanticfor word-boundary-aligned highlightscopy-deps.jsuses esbuild to bundle it into a browser-ready IIFE (8.9KB)applyWordDiffToHtmland all guard clauses unchanged — return type{ oldRanges, newRanges }preservedWhy: Google's
diff-match-patchis archived.@sanity/diff-match-patchis a maintained TypeScript rewrite (~492K weekly npm downloads) that merges bugfixes Google never accepted.Companion PR: tomasz-tomczyk/crit-web#101 (pending)
Test plan
word-diff.spec.tspassessuggestion-diff.spec.tspasses🤖 Generated with Claude Code