fix: prevent stale pointer writes in RefreshDiffs#345
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 24, 2026
Merged
Conversation
Look up FileEntry by path in the write-lock section instead of using pointers captured under the earlier read-lock. If RefreshFileList runs between the two lock sections (possible during concurrent agent requests), the captured pointers could reference orphaned entries, silently losing diff updates. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*FileEntrypointers with path-based lookups in the write-lock section ofRefreshDiffs()RefreshFileListruns between the read-lock snapshot and write-lock assignment (possible during concurrent agent requests viarunAgentCmd), captured pointers could reference orphaned entries, silently losing diff updatesTest plan
go build ./...— compiles cleango vet ./...— no issuesgo test ./...— all tests pass🤖 Generated with Claude Code