fix: add response.ok checks and fix doFinishReview error recovery#344
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 24, 2026
Merged
fix: add response.ok checks and fix doFinishReview error recovery#344tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
- Add response.ok validation in submitComment() for both PUT and POST
paths to prevent silent failures when server returns errors
- Move setUIState('waiting') inside try block so fetch failures don't
strand the user on the waiting overlay with no way back
- Fix dead .mermaid-rendered CSS selector to target actual .mermaid class
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
response.okvalidation insubmitComment()for both PUT and POST paths — previously, server errors were silently swallowed and could corrupt the comment array or lose the user's draftsetUIState('waiting')inside try block indoFinishReview()— previously, a fetch failure would strand the user on the waiting overlay with no way to return to editing.mermaid-renderedCSS selector to target actual.mermaidclass used by mermaid diagram renderingTest plan
🤖 Generated with Claude Code