fix: preserve GitHubID in carryForwardComment to prevent duplicate PR comments#340
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 24, 2026
Merged
Conversation
… comments carryForwardComment was copying all Comment fields except GitHubID, so comments pulled from GitHub via `crit pull` lost their GitHub identity after round-complete. This caused `crit push` to treat them as new comments and post duplicates. Fixes #314 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
carryForwardComment()inwatch.gowas missingGitHubIDfield when constructing the carried-forward commentcrit pull) to lose theirGitHubIDafter a round-complete, makingcrit pushtreat them as new comments and post duplicatesCloses #314
Review
Test plan
TestCarryForwardComment_PreservesGitHubIDinwatch_test.goTestCarryForwardCommentinsession_test.goto cover GitHubID-raceflag🤖 Generated with Claude Code