fix: log JSON encode errors in writeJSON#331
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
If json.NewEncoder(w).Encode(v) fails (broken pipe, unencodable type), the error was discarded with `_ =`, leaving the client with a partial or empty 200 response and no server-side indication of failure. Log the error so it is visible in server output. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
9c81055 to
619adc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writeJSONnow logs encode failures vialog.Printfinstead of silently dropping themlog.Printfusage elsewhere inserver.goTest plan
go vet ./...cleango test -race -count=1 ./...passes🤖 Generated with Claude Code