fix: wrap errors in atomicWriteFile with operation context#330
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 21, 2026
Merged
fix: wrap errors in atomicWriteFile with operation context#330tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
Each error return in atomicWriteFile now includes which step failed (create, write, sync, close, chmod, rename). Previously, a bare "permission denied" gave no indication of which of the six sequential operations caused the failure. Also wraps the final os.Rename and cleans up the temp file on rename failure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
51448c7 to
186b62a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atomicWriteFilewithfmt.Errorfand%wfor clear operation contextTest plan
go vet ./...cleango test -race -count=1 ./...passes🤖 Generated with Claude Code