feat: render outdated comments inline when lines leave diff hunks#325
Merged
tomasz-tomczyk merged 4 commits intomainfrom Apr 21, 2026
Merged
feat: render outdated comments inline when lines leave diff hunks#325tomasz-tomczyk merged 4 commits intomainfrom
tomasz-tomczyk merged 4 commits intomainfrom
Conversation
When a reviewer comments on a diff line and the agent undoes that change, the file stays in the diff but the commented lines disappear from hunks. The comment existed in file.comments but had no inline anchor — invisible except in the All Comments panel. - Add appendOutdatedDiffComments() that detects unrendered comments after hunk rendering and shows them at the bottom of the diff section - Uses existing outdated-comment/outdated-badge CSS classes (same as orphaned file comments from PR #279) - Called from both renderDiffUnified and renderDiffSplit - Full CRUD support: edit, delete, resolve all work on outdated comments Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… round-complete - Add border-top and padding for .outdated-diff-comments section to visually separate it from diff hunks - Remove unnecessary round-complete call in E2E test beforeEach (follows project convention — only clearAllComments needed) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
- Replace inline request.post calls with addComment from ./helpers (5 occurrences) - Add expect(keys.size).toBeGreaterThan(0) guard in findNonHunkLine to prevent vacuous passes if diff API response shape doesn't match Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Restore threading.spec.ts and activeReplyForms code that were accidentally included from the fix/reply-form-font-size branch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appendOutdatedDiffComments()that detects unrendered comments after hunk rendering and shows them at the bottom of the diff section with "Outdated" badgeoutdated-badgeCSS (same as orphaned files from feat: surface orphaned comments on removed files #279)Review
Test plan
🤖 Generated with Claude Code