Skip to content

fix: preserve reply form state when opening new comment forms#323

Merged
tomasz-tomczyk merged 1 commit intomainfrom
fix/reply-form-persistence
Apr 21, 2026
Merged

fix: preserve reply form state when opening new comment forms#323
tomasz-tomczyk merged 1 commit intomainfrom
fix/reply-form-persistence

Conversation

@tomasz-tomczyk
Copy link
Copy Markdown
Owner

Summary

  • Reply forms now preserve their expanded state and text content when a new comment form is opened (which triggers a DOM re-render)
  • Added activeReplyForms Map to track reply state across re-renders, analogous to how activeForms preserves comment form state
  • State is cleared on scope changes, session reloads, cancel, and submit

Test plan

  • New E2E test: "reply form persists expanded state and text when opening a new comment form on same file"
  • All 13 threading tests pass
  • All 9 multi-form tests pass

🤖 Generated with Claude Code

Opening a new comment form triggers renderFileByPath which rebuilds
the DOM. Comment forms survive via activeForms tracking, but reply
forms were recreated fresh each time, losing expanded state and text.

Added activeReplyForms Map to track reply form state across re-renders,
analogous to how activeForms preserves comment form state.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@tomasz-tomczyk tomasz-tomczyk merged commit 243bf46 into main Apr 21, 2026
4 checks passed
@tomasz-tomczyk tomasz-tomczyk deleted the fix/reply-form-persistence branch April 21, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant