test: fix live-thread E2E test, add light theme a11y check, fix integration test compile error#316
Merged
tomasz-tomczyk merged 4 commits intomainfrom Apr 20, 2026
Merged
Conversation
The "resolving a live thread collapses it" test was not exercising the actual live-thread code path — it added an agent reply but never called /api/agent/request, so comment.live was always false. Now calls the endpoint to properly set live state and asserts the .live-thread CSS class. Adds light theme axe-core contrast test to catch regressions like the --fg-on-accent bug. Replaces waitForTimeout(100) with waitForFunction. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ration test compile error The "resolving a live thread collapses it" test was not exercising the actual live-thread code path — it added an agent reply but never called /api/agent/request, so comment.live was always false. Now calls the endpoint to properly set live state and asserts the .live-thread CSS class. Adds light theme axe-core contrast test to catch regressions like the --fg-on-accent bug. Replaces waitForTimeout(100) with waitForFunction. Fixes shareFile struct literal in TestShareSyncOrphanedFile — the Orphaned field doesn't exist on shareFile (orphaned status is conveyed via Status: "removed"). This was a compile error only visible with -tags integration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replaces the mock-based TestShareSyncOrphanedFile with a real end-to-end test that shares an orphaned file (with line and file-level comments) to a running crit-web instance and verifies both files and comments appear correctly via the document and comments APIs. Uses shareFilesToWeb directly rather than the CLI, since orphaned files are shared via the browser share path (LoadShareFilesFromDisk on a live session), not the CLI `crit share` command. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…lock The wrapper element uses class 'comment-block', not 'comment-wrapper'. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/agent/request, socomment.livewas alwaysfalse). Now calls the endpoint and asserts.live-threadCSS class--fg-on-accentbug that only manifested in explicit light modewaitForTimeout(100)withwaitForFunctionchecking computed styleshareFilecompile error inTestShareSyncOrphanedFile—Orphanedfield doesn't exist onshareFile(orphaned status conveyed viaStatus: "removed"). Only visible with-tags integrationTest plan
make e2e— threading and accessibility tests passmake e2e-share— integration tests compile and pass🤖 Generated with Claude Code