Skip to content

test: fix live-thread E2E test, add light theme a11y check, fix integration test compile error#316

Merged
tomasz-tomczyk merged 4 commits intomainfrom
fix/e2e-live-thread-and-a11y-light
Apr 20, 2026
Merged

test: fix live-thread E2E test, add light theme a11y check, fix integration test compile error#316
tomasz-tomczyk merged 4 commits intomainfrom
fix/e2e-live-thread-and-a11y-light

Conversation

@tomasz-tomczyk
Copy link
Copy Markdown
Owner

Summary

  • Fix threading.spec.ts "resolving a live thread collapses it" — was not exercising the live-thread code path (never called /api/agent/request, so comment.live was always false). Now calls the endpoint and asserts .live-thread CSS class
  • Add light theme axe-core contrast test to accessibility.spec.ts — catches regressions like the --fg-on-accent bug that only manifested in explicit light mode
  • Replace waitForTimeout(100) with waitForFunction checking computed style
  • Fix shareFile compile error in TestShareSyncOrphanedFileOrphaned field doesn't exist on shareFile (orphaned status conveyed via Status: "removed"). Only visible with -tags integration

Test plan

  • make e2e — threading and accessibility tests pass
  • make e2e-share — integration tests compile and pass

🤖 Generated with Claude Code

tomasz-tomczyk and others added 4 commits April 20, 2026 07:58
The "resolving a live thread collapses it" test was not exercising the actual
live-thread code path — it added an agent reply but never called
/api/agent/request, so comment.live was always false. Now calls the endpoint
to properly set live state and asserts the .live-thread CSS class.

Adds light theme axe-core contrast test to catch regressions like the
--fg-on-accent bug. Replaces waitForTimeout(100) with waitForFunction.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ration test compile error

The "resolving a live thread collapses it" test was not exercising the actual
live-thread code path — it added an agent reply but never called
/api/agent/request, so comment.live was always false. Now calls the endpoint
to properly set live state and asserts the .live-thread CSS class.

Adds light theme axe-core contrast test to catch regressions like the
--fg-on-accent bug. Replaces waitForTimeout(100) with waitForFunction.

Fixes shareFile struct literal in TestShareSyncOrphanedFile — the Orphaned
field doesn't exist on shareFile (orphaned status is conveyed via Status:
"removed"). This was a compile error only visible with -tags integration.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replaces the mock-based TestShareSyncOrphanedFile with a real end-to-end
test that shares an orphaned file (with line and file-level comments) to
a running crit-web instance and verifies both files and comments appear
correctly via the document and comments APIs.

Uses shareFilesToWeb directly rather than the CLI, since orphaned files
are shared via the browser share path (LoadShareFilesFromDisk on a live
session), not the CLI `crit share` command.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…lock

The wrapper element uses class 'comment-block', not 'comment-wrapper'.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@tomasz-tomczyk tomasz-tomczyk merged commit 82aa573 into main Apr 20, 2026
4 checks passed
@tomasz-tomczyk tomasz-tomczyk deleted the fix/e2e-live-thread-and-a11y-light branch April 20, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant