fix: use server-side Live field for live badge instead of reply author heuristic#311
Merged
tomasz-tomczyk merged 3 commits intomainfrom Apr 19, 2026
Merged
Conversation
…e badge The live badge was showing on any thread where the agent had replied (e.g. via CLI `crit comment --reply-to`), not just threads explicitly sent to the agent via "Send to Agent". Now `isLiveThread()` reads `comment.live` which is set server-side by `POST /api/agent/request`. Fixes #262 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The live badge was incorrectly shown on threads with agent-authored CLI replies, not just comments actually sent via "Send to Agent". This adds a `Live` bool field to Comment that is explicitly set to true only when handleAgentRequest dispatches the comment to the agent command. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add Live to carryForwardComment struct literal to prevent silent data loss across round transitions - Remove TestHandleAgentRequest_SetsLive from server_test.go (already covered in server_agent_test.go) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Livebool field toCommentstruct, set server-side whenPOST /api/agent/requestis calledisLiveThread()in frontend to checkcomment.liveinstead of scanning reply authorsLivefield across round transitions incarryForwardCommentCloses #262
Review
Test plan
go test ./...— all pass🤖 Generated with Claude Code