refactor: Go cleanup — 5 audit fixes#145
Merged
tomasz-tomczyk merged 2 commits intomainfrom Mar 19, 2026
Merged
Conversation
…fig merge, clean comments 1. Remove unused filePath param from collectNewRepliesForPush 2. Extract shared skipDirs map used by both WalkFiles and walkDirectory 3. Fix mergeConfigs boolean reset: use configPresence tracking so project no_open:false can override global no_open:true 4. Refactor FileDiffForCommit to use switch on exit code instead of repeated *exec.ExitError type assertions 5. Fix stale comment on filterPathsIgnored (used in production, not test-only) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…DOM queries
- Remove unused diff-match-patch vendor file, script tag, copy-deps entry,
and package.json dependency (dead since LCS rewrite)
- Consolidate duplicate CSS rules: .line-block-modified/.line-block-changed,
.selected/.form-selected/.focused background declarations, and
unified/split diff selected/form-selected rules
- Remove dead .line-content h6 color declaration overridden by specific rule
- Cache getElementById('commitDropdown') into commitDropdownEl
- Fix var → const/let in newer functions (word-diff LCS, file-picker,
commit picker, relativeTime, reloadForScope)
- Replace E2E tests that exercised diff_match_patch directly with tests
that validate actual LCS-based word-diff rendering behavior
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filePathparam fromcollectNewRepliesForPush— the parameter was never used and the caller passed""skipDirsmap in git.go used by bothWalkFilesandwalkDirectoryso they can't silently divergemergeConfigsboolean reset — useconfigPresencetracking so projectno_open: falsecan override globalno_open: true(previously impossible due to zero-value checks)FileDiffForCommit— replace repeated*exec.ExitErrortype assertions with a single assertion and switch on exit codefilterPathsIgnored— function is used in production byhandleFilesList, not test-onlyTest plan
go buildcompiles cleanlygo test ./...passes (includes newTestMergeConfigsBoolOverridetest)🤖 Generated with Claude Code