You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a user edits the body of a comment that was already pushed to GitHub (i.e. has a non-zero github_id), the next crit push is a no-op (No comments to push.) and the remote body stays at its original value. The edit is silently dropped.
Reproducer
TestRoundtrip_EditPushedCommentBody in roundtrip_integration_test.go (e2e_github tag):
crit comment sample.go:19 'original body'
crit push → remote ID assigned, count=1
Edit the review file: change body from original body to edited body
crit push → output is No comments to push.; remote still has original body
Expected
GitHub's review-comment API supports PATCH repos/{owner}/{repo}/pulls/comments/{id}. Push should issue PATCH for comments whose local body diverges from the last-known remote body. Remote count stays 1, remote ID unchanged, remote body matches local.
Actual failure output
=== RUN TestRoundtrip_EditPushedCommentBody
roundtrip_integration_test.go:445: push #2 output:
No comments to push.
roundtrip_integration_test.go:455: remote body did not update: got "original body", want "edited body"
--- FAIL: TestRoundtrip_EditPushedCommentBody (11.46s)
Notes
This is the literal "comments getting recreated whole" / "edits don't propagate" symptom from earlier reports.
Summary
When a user edits the body of a comment that was already pushed to GitHub (i.e. has a non-zero
github_id), the nextcrit pushis a no-op (No comments to push.) and the remote body stays at its original value. The edit is silently dropped.Reproducer
TestRoundtrip_EditPushedCommentBodyinroundtrip_integration_test.go(e2e_github tag):crit comment sample.go:19 'original body'crit push→ remote ID assigned, count=1bodyfromoriginal bodytoedited bodycrit push→ output isNo comments to push.; remote still hasoriginal bodyExpected
GitHub's review-comment API supports
PATCH repos/{owner}/{repo}/pulls/comments/{id}. Push should issue PATCH for comments whose local body diverges from the last-known remote body. Remote count stays 1, remote ID unchanged, remote body matches local.Actual failure output
Notes
Test is being skipped with
t.Skip("blocked on issue #N: ...")pending a fix.