refac(subscriber): make Callsites length const generic#87
Merged
Conversation
Currently, callsites arrays always have 32 elements. This is fine for task spans and waker ops. However, when adding async resources and async operations, these will likely need to be much longer. This PR changes the `Callsites` type to have a const generic parameter for the maximum number of callsites. When using `Callsites` to track async ops and resources, we can provide a much larger length value
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
seanmonstar
approved these changes
Aug 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, callsites arrays always have 32 elements. This is fine for
task spans and waker ops. However, when adding async resources and async
operations, these will likely need to be much longer.
This PR changes the
Callsitestype to have a const generic parameterfor the maximum number of callsites. When using
Callsitesto trackasync ops and resources, we can provide a much larger length value.
I also tuned the length of the two callsites arrays we're currently using, and
added a quick
fmt::Debugimpl forTasksLayer.