test(subscriber): add tests for excessive poll counts#476
Merged
Conversation
A defect in the way polls are counted was fixed in #440. The defect caused the polls of a "child" task to also be counted on the "parent" task. Where in this case, the "parent" is a task that spawns the "child" task. This change adds a regression test for that fix. To do so, functionality to record and validate poll counts is added to the `console-subscriber` integration test framework. The new functionality is also used to add some basic tests for poll counts.
hawkw
approved these changes
Nov 16, 2023
hawkw
approved these changes
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A defect in the way polls are counted was fixed in #440. The defect
caused the polls of a "child" task to also be counted on the "parent"
task. Where in this case, the "parent" is a task that spawns the "child"
task.
This change adds a regression test for that fix.
To do so, functionality to record and validate poll counts is added to
the
console-subscriberintegration test framework. The newfunctionality is also used to add some basic tests for poll counts.