Support non-atomic targets by using portable-atomic#751
Closed
tjoslin wants to merge 1 commit intotokio-rs:masterfrom
Closed
Support non-atomic targets by using portable-atomic#751tjoslin wants to merge 1 commit intotokio-rs:masterfrom
tjoslin wants to merge 1 commit intotokio-rs:masterfrom
Conversation
squashed commits from upstream tokio-rs#467 and rebased with updated deps
3db5c8a to
4ab579f
Compare
In the worst case, you can always add |
Author
Yeah, if they do not have bandwidth to continue their PR that's a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
squashed commits from upstream #467 by @taiki-e and rebased with updated deps and resolved conflicts
I'm not sure this should be merged as-is because the original author would lose credit but given the comments on #467 I figured this was a useful exercise to see what else would be necessary to add before a merge could occur.