Skip to content

Restore commented tests#665

Merged
carllerche merged 2 commits intotokio-rs:masterfrom
braddunbar:uncomment-tests
Feb 6, 2024
Merged

Restore commented tests#665
carllerche merged 2 commits intotokio-rs:masterfrom
braddunbar:uncomment-tests

Conversation

@braddunbar
Copy link
Copy Markdown
Contributor

These seem to have been commented by accident in #298, and are still passing. All of the functionality under test here seems to still be relevant.

These seem to have been commented by accident in tokio-rs#298, and are still
passing.
No need to build these in dev/release mode.
@braddunbar
Copy link
Copy Markdown
Contributor Author

Added one more commit to move them into a tests module.

Copy link
Copy Markdown
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carllerche carllerche merged commit 8bcac21 into tokio-rs:master Feb 6, 2024
@braddunbar braddunbar mentioned this pull request Mar 22, 2024
@braddunbar braddunbar deleted the uncomment-tests branch March 24, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants