Skip to content

Bump golangci-lint from v2.1.6 to v2.11.4#23

Merged
metalarm10 merged 3 commits into
masterfrom
john/bump-golangci-lint-v2.11.4
Apr 17, 2026
Merged

Bump golangci-lint from v2.1.6 to v2.11.4#23
metalarm10 merged 3 commits into
masterfrom
john/bump-golangci-lint-v2.11.4

Conversation

@metalarm10

@metalarm10 metalarm10 commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Closes: https://app.clickup.com/t/868hgq2tr

Description

  • Bump golangci-lint from v2.1.6 to v2.11.4

Newly disabled linters

Linters introduced after v2.1.6 with medium & low priority are disabled to maintain parity and avoid a large diff in downstream repos.

  • modernize: Suggests modern Go idioms — e.g., slices.Contains over manual loops, errors.As over type assertions, fmt.Appendf over fmt.Sprintf etc. 50+ issues across tx-chain
  • noinlineerr: Warns against inlined error returns like return fmt.Errorf(...) - wants errors assigned to a named variable before returning. 632 issues, stylistic (no bug detection value)

Linters that were new but had low issue counts (embeddedstructfieldcheck, godoclint) are enabled - fixes applied in the tx-chain companion PR.

Go version

Not bumped. tx-chain uses Go 1.24.6 which is already above the minimum required by our current Cosmos SDK v0.53.6 (Go 1.23.2).
Go will be bumped alongside the Cosmos SDK v0.54 upgrade, which requires Go version 1.25.9.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@metalarm10 metalarm10 requested a review from a team as a code owner April 17, 2026 08:15
@metalarm10 metalarm10 requested review from TxCorpi0x and ysv and removed request for a team April 17, 2026 08:15

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 19 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on TxCorpi0x).

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TxCorpi0x reviewed 19 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on metalarm10).

@metalarm10 metalarm10 merged commit a5fb16a into master Apr 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants