Fix Missed Lint Issues#94
Merged
Merged
Conversation
ysv
approved these changes
Feb 25, 2026
ysv
left a comment
Contributor
There was a problem hiding this comment.
@ysv reviewed 8 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on masihyeganeh, metalarm10, and miladz68).
masihyeganeh
approved these changes
Feb 26, 2026
masihyeganeh
left a comment
Contributor
There was a problem hiding this comment.
@masihyeganeh reviewed 8 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on metalarm10 and miladz68).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several improvements and updates across the codebase, focusing on dependency updates, test cleanup, and minor bug fixes. The most significant changes are grouped below by theme.
Dependency and Build Updates:
github.com/tokenize-x/tx-chain/v7,github.com/tokenize-x/tx-crust, andgithub.com/tokenize-x/tx-crust/znetdependencies inbuild/go.modandgo.work.sumto the latest versions, ensuring the project the fixes for linting for repos with more than one go modules. [1] [2]breakingProtolint check inbuild/tx-chain/build.goand clarified the usage of the embedded template inbuild/tx-chain/generate-proto-breaking.go. [1] [2]build/tx-chain/images.go.Integration Test Improvements and Fixes:
integration-tests/ibc/ibc_v2_test.goto consistently use(ctx context.Context, t *testing.T, ...)ordering, improving readability and aligning with Go best practices. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]require.Positiveinstead ofrequire.Greaterfor height checks, correct assignment of proof heights, and improved usage of gRPC clients. [1] [2] [3] [4]Test Assertion Cleanup:
integration-tests/modules/pse_test.go, usingrequireT.Emptyinstead ofrequireT.Len(..., 0)for better clarity. [1] [2]Reviewers checklist:
Authors checklist
This change is