Skip to content

Fix Missed Lint Issues#94

Merged
TxCorpi0x merged 2 commits into
masterfrom
mehdi/fix-missed-lint-issues
Feb 26, 2026
Merged

Fix Missed Lint Issues#94
TxCorpi0x merged 2 commits into
masterfrom
mehdi/fix-missed-lint-issues

Conversation

@TxCorpi0x

@TxCorpi0x TxCorpi0x commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Description

This pull request includes several improvements and updates across the codebase, focusing on dependency updates, test cleanup, and minor bug fixes. The most significant changes are grouped below by theme.

Dependency and Build Updates:

  • Updated github.com/tokenize-x/tx-chain/v7, github.com/tokenize-x/tx-crust, and github.com/tokenize-x/tx-crust/znet dependencies in build/go.mod and go.work.sum to the latest versions, ensuring the project the fixes for linting for repos with more than one go modules. [1] [2]
  • Re-enabled the breakingProto lint check in build/tx-chain/build.go and clarified the usage of the embedded template in build/tx-chain/generate-proto-breaking.go. [1] [2]
  • Simplified logic for determining when to use a local binary in Docker builds in build/tx-chain/images.go.

Integration Test Improvements and Fixes:

  • Refactored integration test helper function signatures in integration-tests/ibc/ibc_v2_test.go to consistently use (ctx context.Context, t *testing.T, ...) ordering, improving readability and aligning with Go best practices. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]
  • Fixed minor bugs in IBC v2 test logic, including correct use of require.Positive instead of require.Greater for height checks, correct assignment of proof heights, and improved usage of gRPC clients. [1] [2] [3] [4]

Test Assertion Cleanup:

  • Replaced deprecated or less clear assertions with more idiomatic ones in integration-tests/modules/pse_test.go, using requireT.Empty instead of requireT.Len(..., 0) for better clarity. [1] [2]

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@TxCorpi0x TxCorpi0x requested a review from a team as a code owner February 25, 2026 10:53
@TxCorpi0x TxCorpi0x requested review from masihyeganeh, metalarm10, miladz68 and ysv and removed request for a team February 25, 2026 10:53

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 8 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on masihyeganeh, metalarm10, and miladz68).

@masihyeganeh masihyeganeh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masihyeganeh reviewed 8 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on metalarm10 and miladz68).

@TxCorpi0x TxCorpi0x merged commit 773e958 into master Feb 26, 2026
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants