Fix migrate-keyring CLI to include address reverse-lookup entries#89
Conversation
ysv
left a comment
There was a problem hiding this comment.
@ysv reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on masihyeganeh, metalarm10, miladz68, and TxCorpi0x).
cmd/txd/cosmoscmd/migrate_keyring.go line 154 at r1 (raw file):
} return 1
why do we need to return 0/1 if we never use this returned value ?
metalarm10
left a comment
There was a problem hiding this comment.
@metalarm10 made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on masihyeganeh, miladz68, TxCorpi0x, and ysv).
cmd/txd/cosmoscmd/migrate_keyring.go line 154 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
why do we need to return 0/1 if we never use this returned value ?
Done.
ysv
left a comment
There was a problem hiding this comment.
@ysv reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on masihyeganeh, miladz68, and TxCorpi0x).
masihyeganeh
left a comment
There was a problem hiding this comment.
@masihyeganeh reviewed 1 file and all commit messages.
Reviewable status:
Description
QA reported: After selective key migration (e.g.
txd keys migrate-keyring alice), the.infoentry (alice.info) was migrated successfully. Users could look up keys by name (--from alice). But lookups by bech32 address (--from testcore1k343...) failed with "key not found".This broke:
--from <address>flagThis PR fixes the issue: After migrating each
.infoentry, unmarshal the hex address, then migrate the corresponding<hex>.addressentry as well.Verified on coreum-testnet-1: key migration, address lookup, bank send with
--from <address>, and group proposal submission tests passed.Reviewers checklist:
Authors checklist
This change is