Skip to content

Implement CLI for migrating OS keyring keys#81

Merged
metalarm10 merged 3 commits into
masterfrom
fix/os-keyring-migration
Feb 17, 2026
Merged

Implement CLI for migrating OS keyring keys#81
metalarm10 merged 3 commits into
masterfrom
fix/os-keyring-migration

Conversation

@metalarm10

@metalarm10 metalarm10 commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

Description

OS keyring backend uses version.Name as keychain namespace. cored uses "coreum", txd uses "tx-chain" - keys are invisible across binaries.
Adds txd keys migrate-keyring to copy keys from coreum into tx-chain namespace.

Usage: txd keys migrate-keyring

Note: Keys are copied, not moved. Original keys remain in the source namespace for safety.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@metalarm10 metalarm10 requested a review from a team as a code owner February 12, 2026 14:53
@metalarm10 metalarm10 requested review from TxCorpi0x, masihyeganeh, miladz68 and ysv and removed request for a team February 12, 2026 14:53
masihyeganeh
masihyeganeh previously approved these changes Feb 13, 2026

@masihyeganeh masihyeganeh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masihyeganeh reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68, @TxCorpi0x, and @ysv).

@masihyeganeh masihyeganeh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masihyeganeh reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68, @TxCorpi0x, and @ysv).

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on miladz68 and TxCorpi0x).

@metalarm10 metalarm10 merged commit 47ecb18 into master Feb 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants