Skip to content

Implemented data types for pse snapshoting#7

Merged
miladz68 merged 3 commits into
masterfrom
milad/pse-snapshot-types
Oct 23, 2025
Merged

Implemented data types for pse snapshoting#7
miladz68 merged 3 commits into
masterfrom
milad/pse-snapshot-types

Conversation

@miladz68

@miladz68 miladz68 commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested review from TxCorpi0x and masihyeganeh and removed request for TxCorpi0x October 22, 2025 10:58

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to mention, there are some comment related to feemodel and fee module, I think they are left from the previous PR

@masihyeganeh masihyeganeh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masihyeganeh reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68)

@masihyeganeh masihyeganeh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68)

@miladz68 miladz68 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I will make a PR to fix those left overs.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68)

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, and please don't forget mgs.go => msg.go

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68)

@miladz68 miladz68 merged commit 1950729 into master Oct 23, 2025
15 of 16 checks passed
@miladz68 miladz68 deleted the milad/pse-snapshot-types branch October 23, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants