Bump ledger-related deps to fix ledger signing#68
Conversation
ysv
left a comment
There was a problem hiding this comment.
@ysv made 1 comment.
Reviewable status: 0 of 22 files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi, @masihyeganeh, @metalarm10, @miladz68, and @TxCorpi0x).
a discussion (no related file):
Most of the changes are related to linter fixes caused by cosmos-sdk update
miladz68
left a comment
There was a problem hiding this comment.
@miladz68 reviewed 22 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi, @masihyeganeh, @metalarm10, and @TxCorpi0x).
masihyeganeh
left a comment
There was a problem hiding this comment.
@masihyeganeh reviewed 22 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @akhlopiachyi, @metalarm10, @TxCorpi0x, and @ysv).
cmd/txd/cosmoscmd/init.go line 60 at r1 (raw file):
} _, err = fmt.Fprintf(os.Stderr, "%s\n", sdk.MustSortJSON(out))
Was this for convenience, or to make the output deterministic?
ysv
left a comment
There was a problem hiding this comment.
@ysv made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @akhlopiachyi, @masihyeganeh, @metalarm10, and @TxCorpi0x).
cmd/txd/cosmoscmd/init.go line 60 at r1 (raw file):
Previously, masihyeganeh (Masih Yeganeh) wrote…
Was this for convenience, or to make the output deterministic?
This was because MustSortJson method is deprecated
However, I agree we should preserve determinism here
Fixed this in a different way
masihyeganeh
left a comment
There was a problem hiding this comment.
@masihyeganeh reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi, @metalarm10, and @TxCorpi0x).
masihyeganeh
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi, @metalarm10, and @TxCorpi0x).
miladz68
left a comment
There was a problem hiding this comment.
@miladz68 reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi, @metalarm10, and @TxCorpi0x).
Description
Reviewers checklist:
Authors checklist
This change is