Skip to content

Bump ledger-related deps to fix ledger signing#68

Merged
ysv merged 10 commits into
masterfrom
yaroslav/fix-ledger-2
Feb 2, 2026
Merged

Bump ledger-related deps to fix ledger signing#68
ysv merged 10 commits into
masterfrom
yaroslav/fix-ledger-2

Conversation

@ysv

@ysv ysv commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@ysv ysv requested a review from a team as a code owner January 30, 2026 16:47
@ysv ysv requested review from TxCorpi0x, akhlopiachyi, masihyeganeh, metalarm10 and miladz68 and removed request for a team January 30, 2026 16:47

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv made 1 comment.
Reviewable status: 0 of 22 files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi, @masihyeganeh, @metalarm10, @miladz68, and @TxCorpi0x).


a discussion (no related file):
Most of the changes are related to linter fixes caused by cosmos-sdk update

miladz68
miladz68 previously approved these changes Feb 2, 2026

@miladz68 miladz68 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miladz68 reviewed 22 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi, @masihyeganeh, @metalarm10, and @TxCorpi0x).

@masihyeganeh masihyeganeh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masihyeganeh reviewed 22 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @akhlopiachyi, @metalarm10, @TxCorpi0x, and @ysv).


cmd/txd/cosmoscmd/init.go line 60 at r1 (raw file):

	}

	_, err = fmt.Fprintf(os.Stderr, "%s\n", sdk.MustSortJSON(out))

Was this for convenience, or to make the output deterministic?

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @akhlopiachyi, @masihyeganeh, @metalarm10, and @TxCorpi0x).


cmd/txd/cosmoscmd/init.go line 60 at r1 (raw file):

Previously, masihyeganeh (Masih Yeganeh) wrote…

Was this for convenience, or to make the output deterministic?

This was because MustSortJson method is deprecated
However, I agree we should preserve determinism here
Fixed this in a different way

@masihyeganeh masihyeganeh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masihyeganeh reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi, @metalarm10, and @TxCorpi0x).

@masihyeganeh masihyeganeh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi, @metalarm10, and @TxCorpi0x).

@miladz68 miladz68 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miladz68 reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi, @metalarm10, and @TxCorpi0x).

@ysv ysv merged commit 59706fe into master Feb 2, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants