Skip to content

Revert "Add deterministic map implementation and linter (#54)"#66

Merged
miladz68 merged 2 commits into
masterfrom
milad/revert-determinstic-map
Jan 30, 2026
Merged

Revert "Add deterministic map implementation and linter (#54)"#66
miladz68 merged 2 commits into
masterfrom
milad/revert-determinstic-map

Conversation

@miladz68

@miladz68 miladz68 commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

This reverts commit 6c0cee8.

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner January 30, 2026 08:38
@miladz68 miladz68 requested review from TxCorpi0x, akhlopiachyi, masihyeganeh, metalarm10 and ysv and removed request for a team January 30, 2026 08:38

@masihyeganeh masihyeganeh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masihyeganeh reviewed 16 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi, @metalarm10, @miladz68, @TxCorpi0x, and @ysv).


.github/workflows/ci.yml line 73 at r1 (raw file):

      CARGO_NET_GIT_FETCH_WITH_CLI: true
    steps:
      - name: Go version used to build builder

I believe these lines should be after setting up of the ssh

TxCorpi0x
TxCorpi0x previously approved these changes Jan 30, 2026

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TxCorpi0x reviewed 16 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi, @metalarm10, @miladz68, and @ysv).

@miladz68 miladz68 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miladz68 made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi, @masihyeganeh, @metalarm10, and @ysv).


.github/workflows/ci.yml line 73 at r1 (raw file):

Previously, masihyeganeh (Masih Yeganeh) wrote…

I believe these lines should be after setting up of the ssh

Done.

@masihyeganeh masihyeganeh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masihyeganeh reviewed all commit messages and resolved 1 discussion.
Reviewable status: 15 of 16 files reviewed, all discussions resolved (waiting on @akhlopiachyi, @metalarm10, @TxCorpi0x, and @ysv).

@masihyeganeh masihyeganeh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masihyeganeh reviewed 1 file.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @akhlopiachyi, @metalarm10, and @ysv).

@miladz68 miladz68 merged commit 9613e0c into master Jan 30, 2026
15 of 16 checks passed
@miladz68 miladz68 deleted the milad/revert-determinstic-map branch January 30, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants