Skip to content

Build local-only in linux#57

Merged
masihyeganeh merged 18 commits into
masterfrom
build-local-only-in-linux
Feb 12, 2026
Merged

Build local-only in linux#57
masihyeganeh merged 18 commits into
masterfrom
build-local-only-in-linux

Conversation

@masihyeganeh

@masihyeganeh masihyeganeh commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@masihyeganeh masihyeganeh requested a review from a team as a code owner January 6, 2026 12:30
@masihyeganeh masihyeganeh requested review from TxCorpi0x, metalarm10 and miladz68 and removed request for a team January 6, 2026 12:30
@masihyeganeh masihyeganeh force-pushed the build-local-only-in-linux branch from ab9e7d5 to b839da6 Compare January 6, 2026 14:47

@miladz68 miladz68 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miladz68 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @metalarm10, and @TxCorpi0x).


build/tx-chain/images.go line 30 at r1 (raw file):

// BuildTXdDockerImage builds txd docker image.
func BuildTXdDockerImage(ctx context.Context, deps types.DepsFunc) error {
	// skip building TXd in docker for Linux builds to avoid using the large GoReleaser when unnecessary

I think we should discuss the idea behind this and what we are trying to achieve.
In short, I think the original problem is that some repositories don't have enough storage storage; to get around it we can use a pre-build binary instead of building locally ?

@masihyeganeh masihyeganeh force-pushed the build-local-only-in-linux branch from 9b5c4b2 to d82755b Compare February 11, 2026 11:46

@masihyeganeh masihyeganeh left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masihyeganeh made 1 comment.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @metalarm10, @miladz68, and @TxCorpi0x).


build/tx-chain/images.go line 30 at r1 (raw file):

Previously, miladz68 (milad) wrote…

I think we should discuss the idea behind this and what we are trying to achieve.
In short, I think the original problem is that some repositories don't have enough storage storage; to get around it we can use a pre-build binary instead of building locally ?

For every other project it works, but the tx-chain itself should build itself locally each time

@masihyeganeh masihyeganeh left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masihyeganeh reviewed 8 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @metalarm10, @miladz68, and @TxCorpi0x).

miladz68
miladz68 previously approved these changes Feb 11, 2026

@miladz68 miladz68 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miladz68 reviewed 8 files and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @metalarm10 and @TxCorpi0x).

TxCorpi0x
TxCorpi0x previously approved these changes Feb 11, 2026

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masihyeganeh Just to double check before merge.
I tried to remove everything (crust remove) and also tried to remove the local bin directory contents and .cashe and tried the make build images then make znet-start, but i faced an error that compained about missing binary in the .cache/txd/darwin.arm64/bin/txd, so i had to manually copy the txd binary from bin directory to the cache dir.

May be with this simulation, it would be simply fixable here.

@TxCorpi0x reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @metalarm10).

@masihyeganeh masihyeganeh left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TxCorpi0x I already tried that and it worked (at least in my Mac machine. I would need someone with linux machine to test that. Maybe @miladz68 can help me here). If you faced it in other repos, please let me know. But this will fix that.

@masihyeganeh made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @metalarm10).

@masihyeganeh masihyeganeh dismissed stale reviews from TxCorpi0x and miladz68 via 0665447 February 11, 2026 14:43

@masihyeganeh masihyeganeh left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masihyeganeh reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @metalarm10).

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masihyeganeh Nice, it is fixed

@TxCorpi0x reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @metalarm10).

@masihyeganeh masihyeganeh merged commit 3f0746c into master Feb 12, 2026
19 of 34 checks passed
@masihyeganeh masihyeganeh deleted the build-local-only-in-linux branch February 12, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants