Build local-only in linux#57
Conversation
ab9e7d5 to
b839da6
Compare
miladz68
left a comment
There was a problem hiding this comment.
@miladz68 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @metalarm10, and @TxCorpi0x).
build/tx-chain/images.go line 30 at r1 (raw file):
// BuildTXdDockerImage builds txd docker image. func BuildTXdDockerImage(ctx context.Context, deps types.DepsFunc) error { // skip building TXd in docker for Linux builds to avoid using the large GoReleaser when unnecessary
I think we should discuss the idea behind this and what we are trying to achieve.
In short, I think the original problem is that some repositories don't have enough storage storage; to get around it we can use a pre-build binary instead of building locally ?
# Conflicts: # build/tx-chain/images.go
# Conflicts: # build/go.mod # build/go.sum # go.work.sum
9b5c4b2 to
d82755b
Compare
masihyeganeh
left a comment
There was a problem hiding this comment.
@masihyeganeh made 1 comment.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @metalarm10, @miladz68, and @TxCorpi0x).
build/tx-chain/images.go line 30 at r1 (raw file):
Previously, miladz68 (milad) wrote…
I think we should discuss the idea behind this and what we are trying to achieve.
In short, I think the original problem is that some repositories don't have enough storage storage; to get around it we can use a pre-build binary instead of building locally ?
For every other project it works, but the tx-chain itself should build itself locally each time
masihyeganeh
left a comment
There was a problem hiding this comment.
@masihyeganeh reviewed 8 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @metalarm10, @miladz68, and @TxCorpi0x).
miladz68
left a comment
There was a problem hiding this comment.
@miladz68 reviewed 8 files and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @metalarm10 and @TxCorpi0x).
TxCorpi0x
left a comment
There was a problem hiding this comment.
@masihyeganeh Just to double check before merge.
I tried to remove everything (crust remove) and also tried to remove the local bin directory contents and .cashe and tried the make build images then make znet-start, but i faced an error that compained about missing binary in the .cache/txd/darwin.arm64/bin/txd, so i had to manually copy the txd binary from bin directory to the cache dir.
May be with this simulation, it would be simply fixable here.
@TxCorpi0x reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @metalarm10).
masihyeganeh
left a comment
There was a problem hiding this comment.
@TxCorpi0x I already tried that and it worked (at least in my Mac machine. I would need someone with linux machine to test that. Maybe @miladz68 can help me here). If you faced it in other repos, please let me know. But this will fix that.
@masihyeganeh made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @metalarm10).
0665447
masihyeganeh
left a comment
There was a problem hiding this comment.
@masihyeganeh reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @metalarm10).
TxCorpi0x
left a comment
There was a problem hiding this comment.
@masihyeganeh Nice, it is fixed
@TxCorpi0x reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @metalarm10).
Description
Reviewers checklist:
Authors checklist
This change is